dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3b73014) | patch
Fix UploadBase::checkXMLEncodingMissmatch() on PHP 7.1+
authorKunal Mehta <legoktm@member.fsf.org>
Thu, 7 Jun 2018 00:54:07 +0000 (17:54 -0700)
committerKunal Mehta <legoktm@member.fsf.org>
Thu, 7 Jun 2018 03:13:13 +0000 (20:13 -0700)
commit827cfb3351db57332e16db48bdfbcde6131c17cd
treee3e2bd3f739c5d213bc580eab157f9d17aec6bebtree | snapshot
parent3b73014c55b75485366e25ea4b44f65a5f407bd3commit | diff
Fix UploadBase::checkXMLEncodingMissmatch() on PHP 7.1+

file_get_contents() started supporting a negative offset in 7.1+. But
we really just want to start with 0.

Also fix the order of arguments to assertSame() so that the expected
value is first.

Bug: T182366
Change-Id: I84c92652de5b51a43f6e2b58cd235d2889093453
RELEASE-NOTES-1.31 diff | blob | history
includes/upload/UploadBase.php diff | blob | history
tests/phpunit/includes/upload/UploadBaseTest.php diff | blob | history
Wiklou, le Wiki du Wiklou